Fix object identity bug in Ruby-to-JavaScript conversion #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where separate Ruby objects with identical content were
incorrectly sharing the same JavaScript object reference during serialization.
Problem:
- Ruby hashes like [{"value" => 42}, {"value" => 42}, {"value" => 42}]
were becoming the same JavaScript object reference
- Mutating one object affected all identical objects
- This happened because serialization used Ruby's content-based hash equality
instead of object identity for reference tracking
Solution:
- Modified serialize1() in mini_racer_extension.c to use rb_obj_id(v) as the
hash key instead of the object itself (v)
- This ensures only truly identical Ruby objects (same memory address) share
JavaScript references, preserving circular reference handling
- Separate Ruby objects now correctly become separate JavaScript objects
Changes:
- ext/mini_racer_extension/mini_racer_extension.c: Use object identity for refs
- test/test_object_identity_fix.rb: Comprehensive regression tests
Tests:
- All existing tests pass (97 runs, 171 assertions, 0 failures)
- New regression tests verify both separate and shared object scenarios
- Validates fix for nested objects and circular references
Collaborator
|
Thanks so much, will leave @bnoordhuis to have a review, love the tests. |
Contributor
Author
When vibe coding OSS, the least you can do is write some tests 😄 (Hey, that rhymed!) |
Collaborator
|
Expectation management: I'm on vacation and won't be back for another ~1.5 week. |
|
Hi. Could you, please, make a new release with this fix? |
|
I second that, we are running into this issue at the moment |
Collaborator
|
sure will push a new release today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
C is not my area of expertise. Vibe code content warning 😅 - please review as such! Thank you!
This fixes a bug where separate Ruby objects with identical content were incorrectly sharing the same JavaScript object reference during serialization.
Problem:
[{"value" => 42}, {"value" => 42}, {"value" => 42}]were becoming the same JavaScript object referenceSolution:
serialize1()inmini_racer_extension.cto userb_obj_id(v)as the hash key instead of the object itself (v)Changes:
Tests: