This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Added support for windows and mingw. #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the "access" variable as this appears to be a macro on windows.
Collaborator
|
@jarredholman Do you think you can replicate that appveyor magic like over on libv8? |
Author
|
Sure. It will be a bit hackish initially so that it will accept the rc1'd libv8 version |
Collaborator
|
Hmm, maybe we should just release. |
Collaborator
|
I'm having the same problem with the ARM guys again -- I've made the changes they requested but I'm having zero feedback from them. I wrote in the issue last night, no response yet. Your call. |
|
The issue is still present with 3.16.14.8.rc1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on this pull request: rubyjs/libv8#166
Renamed the "access" variable as this appears to be a macro on windows.