Skip to content

sort results o-c-e-a-n in bar chart #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RomneyDa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sort results o-c-e-a-n in bar chart #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions web/src/app/[locale]/result/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,23 @@ interface ResultsProps {
showExpanded?: boolean;
}

const sortResultsInOrder = (results: Domain[]): Domain[] => {
const desiredOrder = ['O', 'C', 'E', 'A', 'N'];

const domainMap = new Map<string, Domain>();
results.forEach(result => {
domainMap.set(result.domain, result);
});

return desiredOrder
.map(domain => domainMap.get(domain))
.filter((domain): domain is Domain => domain !== undefined);
};

const Results = ({ report, showExpanded }: ResultsProps) => {
const t = useTranslations('results');

const sortedResults = sortResultsInOrder(report.results);

return (
<>
Expand Down Expand Up @@ -100,12 +115,12 @@ const Results = ({ report, showExpanded }: ResultsProps) => {
<div className='flex mt-10'>
<h1 className={title()}>{t('theBigFive')}</h1>
</div>
<BarChart max={120} results={report.results} />
<BarChart max={120} results={sortedResults} />
<DomainTabs
results={report.results}
results={sortedResults}
showExpanded={!!showExpanded}
scoreText={t('score')}
/>
</>
);
};
};