Add tests + functionality for streaming to clickhouse #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/clickhouse
branch
5 times, most recently
from
3638bf8 to
bce0a43
Compare
Signed-off-by: Samuel Giddins <[email protected]>
Signed-off-by: Samuel Giddins <[email protected]>
Signed-off-by: Samuel Giddins <[email protected]>
segiddins
force-pushed
the
segiddins/clickhouse
branch
from
bce0a43 to
e66098e
Compare
Signed-off-by: Samuel Giddins <[email protected]>
segiddins
commented
Mar 28, 2025
| S: serde::Serializer, | ||
| { | ||
| lazy_static! { | ||
| static ref USER_AGENT_PARSER: ParseCtx = ParseCtx::new(); |
Contributor
Author
There was a problem hiding this comment.
@iximeow any recommendations for avoiding these two lazy_static!s inside serde serialize methods?
indirect
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to output files for click house to ingest, with a row for each download.