feat: add src id to schema def #6570
Open
+96
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6570 +/- ##
==========================================
- Coverage 79.46% 79.44% -0.02%
==========================================
Files 543 543
Lines 60796 60797 +1
==========================================
- Hits 48309 48298 -11
- Misses 9612 9614 +2
- Partials 2875 2885 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cisse21
force-pushed
the
feat.addSrcIdToSchemaDef
branch
2 times, most recently
from
1d810fb to
6732db0
Compare
🔒 Scanned for secrets using gitleaks 8.28.0
cisse21
force-pushed
the
feat.addSrcIdToSchemaDef
branch
from
6732db0 to
7fdd6b0
Compare
lvrach
approved these changes
Dec 23, 2025
atzoum
reviewed
Dec 23, 2025
🔒 Scanned for secrets using gitleaks 8.28.0
…er-server into feat.addSrcIdToSchemaDef 🔒 Scanned for secrets using gitleaks 8.28.0
atzoum
reviewed
Dec 24, 2025
| Schema: testdata.TrackSchema, | ||
| Hash: proto.SchemaHash(testdata.TrackSchema), | ||
| Sample: []byte("{}"), | ||
| Key: &proto.EventSchemaKey{ |
Contributor
There was a problem hiding this comment.
Why do we need any modification here?
Suggested change
| Key: &proto.EventSchemaKey{ | |
| Key: &testdata.TestEventSchemaKey, |
| EventType: "track", | ||
| EventIdentifier: "event-name", | ||
| } | ||
| require.Equal(t, schemaTransformer.getSchemaKeyFromJob(testdata.TrackEvent, testdata.WriteKeyEnabled), expectedKey) |
Contributor
There was a problem hiding this comment.
why do we need any modification here?
Suggested change
| require.Equal(t, schemaTransformer.getSchemaKeyFromJob(testdata.TrackEvent, testdata.WriteKeyEnabled), expectedKey) | |
| require.Equal(t, schemaTransformer.getSchemaKeyFromJob(testdata.TrackEvent, testdata.WriteKeyEnabled), &testdata.TestEventSchemaKey) |
|
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔒 Scanned for secrets using gitleaks 8.28.0
Description
Added sourceId field to the EventSchemaMessage protobuf definition
Changes:
Linear Ticket
fixes AI-344
Security