chore: added parent cluster and namespace in function name

rudderlabs · Sep 4, 2024 · 7c9157e · 7c9157e
1 parent 57634f1
commit 7c9157e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/util/customTransformer-faas.js b/src/util/customTransformer-faas.js
@@ -8,6 +8,8 @@ const {
   executeFaasFunction,
   FAAS_AST_FN_NAME,
   FAAS_AST_VID,
+  PARENT_NAMESPACE,
+  PARENT_CLUSTER,
 } = require('./openfaas');
 const { getLibraryCodeV1 } = require('./customTransforrmationsStore-v1');
 
@@ -30,6 +32,8 @@ function generateFunctionName(userTransformation, libraryVersionIds, testMode, h
     ids = ids.concat([hashSecret]);
   }
 
+  ids = ids.concat([PARENT_NAMESPACE, PARENT_CLUSTER]);
+
   // FIXME: Why the id's are sorted ?!
   const hash = crypto.createHash('md5').update(`${ids}`).digest('hex');
   return `fn-${userTransformation.workspaceId}-${hash}`.substring(0, 63).toLowerCase();

diff --git a/src/util/openfaas/index.js b/src/util/openfaas/index.js
@@ -436,6 +436,8 @@ module.exports = {
   buildOpenfaasFn,
   FAAS_AST_VID,
   FAAS_AST_FN_NAME,
+  PARENT_NAMESPACE,
+  PARENT_CLUSTER,
   setFunctionInCache,
   reconcileFunction,
 };
diff --git a/test/__tests__/user_transformation.test.js b/test/__tests__/user_transformation.test.js
@@ -95,6 +95,7 @@ const pyfaasFuncName = (workspaceId, versionId, libraryVersionIds=[], hashSecret
   if (hashSecret !== "") {
     ids = ids.concat([hashSecret]);
   }
+  ids = ids.concat(["default", "default"]);
 
   const hash = crypto.createHash('md5').update(`${ids}`).digest('hex');
 
@@ -119,7 +120,7 @@ describe("User transformation utils", () => {
       [],
       false,
       'hash-secret');
-    expect(fnName).toEqual('fn-workspaceid-34a32ade07ebbc7bc5ea795b8200de9f');
+    expect(fnName).toEqual('fn-workspaceid-c9345699beabf6de99a764cdb1a349e5');
   });
 
 });