Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add typecasting for pinterest tag destination #3846

Closed
wants to merge 2 commits into from

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Nov 4, 2024

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

We are adding type casting to interest tag destination

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested a review from a team as a code owner November 4, 2024 10:31
@ItsSudip ItsSudip requested review from aashishmalik and vinayteki95 and removed request for a team November 4, 2024 10:31
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (1032aa2) to head (94b73fa).
Report is 2 commits behind head on hotfix/4112024.

Additional details and impacted files
@@               Coverage Diff               @@
##           hotfix/4112024    #3846   +/-   ##
===============================================
  Coverage           89.01%   89.01%           
===============================================
  Files                 609      609           
  Lines               32892    32892           
  Branches             7768     7766    -2     
===============================================
  Hits                29279    29279           
  Misses               3300     3300           
  Partials              313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 5, 2024

@ItsSudip
Copy link
Member Author

ItsSudip commented Nov 5, 2024

We will release this later.

@ItsSudip ItsSudip closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants