-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(shopify): seperate pixel server side events logic from legacy tracker implementation #3849
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3849 +/- ##
===========================================
+ Coverage 89.01% 89.03% +0.01%
===========================================
Files 609 612 +3
Lines 32904 33059 +155
Branches 7772 7808 +36
===========================================
+ Hits 29291 29433 +142
- Misses 3300 3311 +11
- Partials 313 315 +2 ☔ View full report in Codecov by Sentry. |
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3849/test-report.html |
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
In order to offer a different way of how event properties are now totally conformant to the RudderStack Ecom Spec, and also support a
shopifyDetails
object inside context, on lines of how events from web pixel have been structured, the events from the new RudderStack Pixel App go through the destination transformations introduced in this PR.What is the related Linear task?
Resolves INT-2835
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
These are introduced to separate pixel server side events logic from legacy tracker implementation, to facilitate more granular control over the server side events from the new RudderStack Pixel app on shopify.
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
No existing change to the legacy tracker based app's destination transformation logic.
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
None
Any technical or performance related pointers to consider with the change?
Some code duplication may occur to keep the transformed event same as earlier apart from 2 differences, in context and event properties as mentioned in the description.
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.