feat: http form format #3919
feat: http form format #3919
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3919/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3919 +/- ##
===========================================
+ Coverage 90.48% 90.49% +0.01%
===========================================
Files 615 620 +5
Lines 32359 32523 +164
Branches 7687 7711 +24
===========================================
+ Hits 29281 29433 +152
- Misses 2822 2866 +44
+ Partials 256 224 -32 ☔ View full report in Codecov by Sentry. |
| if (!payload) { | ||
| throw new ConfigurationError('Invalid payload for FORM format'); | ||
| } | ||
| return querystring.stringify(payload); |
There was a problem hiding this comment.
What is the behaviour of querystring.stringify when payload is {}?
Can we add a test case for that if it turns out to be an edge case?
…ormer into feat.http-form-format
aashishmalik
force-pushed
the
feat.http-form-format
branch
from
0a091e3 to
6e7c01b
Compare
|
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
Resolves INT-XXX
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.