Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: property and event name mappings in shopify v2 #3941

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Dec 18, 2024

What are the changes introduced in this PR?

property and event name mappings in shopify pixel transformations

  • fixes payment info event name
  • aligns data type of some fields to RudderStack Ecommerce Spec

What is the related Linear task?

Resolves INT-3026, INT-3021, INT-2838

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Dec 18, 2024
@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners December 18, 2024 04:30
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (0965f30) to head (2bfb88c).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3941      +/-   ##
===========================================
+ Coverage    90.48%   90.50%   +0.01%     
===========================================
  Files          615      620       +5     
  Lines        32359    32522     +163     
  Branches      7687     7710      +23     
===========================================
+ Hits         29281    29433     +152     
- Misses        2822     2865      +43     
+ Partials       256      224      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants