fix: refactor code and add validation for values #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allure Test reports for this run are available at:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3971 +/- ##
===========================================
- Coverage 90.76% 90.75% -0.01%
===========================================
Files 624 622 -2
Lines 32546 32520 -26
Branches 7723 7718 -5
===========================================
- Hits 29540 29515 -25
+ Misses 2750 2749 -1
Partials 256 256 ☔ View full report in Codecov by Sentry. |
|
Allure Test reports for this run are available at:
|
koladilip
reviewed
Jan 10, 2025
src/v0/destinations/google_adwords_offline_conversions/data/TrackAddStoreConversionsConfig.json
Show resolved
Hide resolved
|
Allure Test reports for this run are available at: |
|
yashasvibajpai
approved these changes
Jan 15, 2025
koladilip
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
We are refactoring the code to allocate all the logic related to identifier in one place. We also added a validation to check if provided value is greater than 0 or not. As we are mapping that to
transaction_amount_microsafter multiplying with 1,000,000 and it can't be less than 1000 as per the doc.What is the related Linear task?
Resolves INT-3085 INT-3020
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.