Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor code and add validation for values #3971

Merged
merged 3 commits into from
Jan 20, 2025

chore: update updateConversion conditions to mutually exclusive

215ce66
Select commit
Loading
Failed to load commit list.
Refresh
Merged

fix: refactor code and add validation for values #3971

chore: update updateConversion conditions to mutually exclusive
215ce66
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 14, 2025 in 0s

73.33% of diff hit (target 90.75%)

View this Pull Request on Codecov

73.33% of diff hit (target 90.75%)

Annotations

Check warning on line 358 in src/v0/destinations/google_adwords_offline_conversions/utils.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/v0/destinations/google_adwords_offline_conversions/utils.js#L357-L358 

Added lines #L357 - L358 were not covered by tests

Check warning on line 360 in src/v0/destinations/google_adwords_offline_conversions/utils.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/v0/destinations/google_adwords_offline_conversions/utils.js#L360 

Added line #L360 was not covered by tests

Check warning on line 362 in src/v0/destinations/google_adwords_offline_conversions/utils.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/v0/destinations/google_adwords_offline_conversions/utils.js#L362 

Added line #L362 was not covered by tests
View more details on Codecov