Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing mismatch of schedule field value in clicksend destination #3975

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

manish339k
Copy link
Contributor

What are the changes introduced in this PR?

there was a bug in the method where we are calculating the schedule by adding integer and string, due to this schedule iwas getting calculated wrongly. this PR fixes that issue.

What is the related Linear task?

Resolves INT-3107

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (495343b) to head (fe48359).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3975      +/-   ##
===========================================
- Coverage    90.76%   90.75%   -0.01%     
===========================================
  Files          624      622       -2     
  Lines        32546    32519      -27     
  Branches      7723     7717       -6     
===========================================
- Hits         29540    29514      -26     
+ Misses        2750     2749       -1     
  Partials       256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@manish339k manish339k merged commit 12e8a52 into develop Jan 16, 2025
27 checks passed
@manish339k manish339k deleted the fix.clicksend_schedule branch January 16, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants