Skip to content

Conversation

@ItsSudip
Copy link
Member

What are the changes introduced in this PR?

We are updating the variable name as per the server, in the amplitude destination to be collected in metric. For reference https://github.com/rudderlabs/rudder-server/blob/0fed2bae8b7edcd9db20f201629f6c4f42f6734c/backend-config/types.go#L55

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested a review from a team as a code owner November 10, 2025 06:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Summary by CodeRabbit

  • Bug Fixes
    • Corrected destination ID tracking in batch response data for improved accuracy.

Walkthrough

Updated a single reference in createBatchResponse: the histogram's destination_id now uses destination.ID (capitalized) instead of destination.id; no other logic or signatures changed.

Changes

Cohort / File(s) Change Summary
Property case correction in histogram
src/v0/destinations/am/transform.js
Replaced destination.id with destination.ID for the destination_id field inside createBatchResponse histogram generation. No other code paths or exports modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify destination.ID is the canonical property on destination objects in this codepath.
  • Confirm no other modules expect destination.id (search for usages).

Suggested reviewers

  • achettyiitr
  • saikumarrs
  • krishna2020

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately reflects the main change: updating a variable name in the Amplitude destination to match the server convention.
Description check ✅ Passed The PR description follows the repository template with all required sections completed, including the objectives, related Linear task, and developer/reviewer checklists.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/updateVariableName

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d23f79 and 5ffa428.

📒 Files selected for processing (1)
  • src/v0/destinations/am/transform.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/v0/destinations/am/transform.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Build User Transformer Docker Image - PR / Build Transformer Docker Image ARM64
  • GitHub Check: Build User Transformer Docker Image - PR / Build Transformer Docker Image AMD64
  • GitHub Check: Build Transformer Docker Image - PR / Build Transformer Docker Image ARM64
  • GitHub Check: Build Transformer Docker Image - PR / Build Transformer Docker Image AMD64
  • GitHub Check: Code Coverage
  • GitHub Check: UT Tests
  • GitHub Check: test_and_publish
  • GitHub Check: Check for formatting & lint errors
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.97%. Comparing base (10c5c29) to head (5ffa428).
⚠️ Report is 77 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4759   +/-   ##
========================================
  Coverage    91.97%   91.97%           
========================================
  Files          655      655           
  Lines        34871    34877    +6     
  Branches      8201     8204    +3     
========================================
+ Hits         32073    32079    +6     
- Misses        2549     2568   +19     
+ Partials       249      230   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@ItsSudip ItsSudip force-pushed the chore/updateVariableName branch from 3e42fca to 5ffa428 Compare November 17, 2025 04:31
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants