avm1: Allow non-object prototypes in Object::new
#22397
Open
+105
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm1
Lord-McSweeney
approved these changes
Dec 3, 2025
Progresses some Gnash tests
moulins
force-pushed
the
avm1-non-object-prototypes
branch
from
b1847bf to
a7c4027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses some Gnash tests.
Note that the new failure in
from_gnash/actionscript.all/Object-v5isn't actually a regression: our behavior was already wrong before this PR (we were coercing a missing prototype to an object, whereas the test is expecting an actual prototype to be present; see here for context).