Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the project to nightly rust to make use of the unstable bindeps cargo feature.
This allows us to cleanly pull the firmware into the flasher tool without having to reinvoke cargo from within a build.rs.
The previous implementation was fine and I wouldnt recommend swapping to nightly just for this, but I think this feature is really cool and I would like to use this project as a testbed for the feature so I can contribute towards seeing it stabilized.
That said there are some really nice wins here:
all the benefits of keeping the project in one workspace:Does not seem to be possible. Maybe one day... Instead I have a workspace including the flasher but excluding the firmware.cargo fmt
,cargo clippy
etc run on all the packages at once.I can remove the manual workarounds from cargo-dist needed because the root of the repo wasnt the root of the crate.I could have just done this anyway by adding a workspace consisting only of the flasher, which I have now done.