-
Notifications
You must be signed in to change notification settings - Fork 22
Add Hyperdisk support for GCE machine types #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rluisr
wants to merge
4
commits into
runatlantis:main
Choose a base branch
from
rluisr:feature/hyperdisk-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12165bc to
984a698
Compare
Author
Author
|
I couldn't boot into COS on ARM. module "atlantis" {
#source = "runatlantis/atlantis/gce"
source = "git::https://github.com/rluisr/terraform-gce-atlantis.git?ref=feature/hyperdisk-support"
name = "atlantis"
image = "ghcr.io/runatlantis/atlantis:v0.34.0"
domain = local.atlantis_domain
project = data.google_project.project.project_id
network = data.google_compute_network.default.id
subnetwork = data.google_compute_subnetwork.default.id
region = "asia-northeast1"
zone = "asia-northeast1-b"
machine_type = "c4a-highcpu-4"
persistent_disk_type = "hyperdisk-balanced"
} |
Author
|
x86/64 machine + hyperdisk is working perfectly. |
This commit adds automatic detection and support for Hyperdisk-only machine types (C4A, C4D, H4D, X4, M4, A4X, A4, A3 Ultra, A3 Mega). The module now automatically switches to hyperdisk-balanced for both boot and persistent disks when these machine types are detected, while still allowing explicit overrides via the new boot_disk_type variable and existing persistent_disk_type variable. Changes: - Added automatic detection for Hyperdisk-only machine families - Added boot_disk_type variable for boot disk type override - Added validation to prevent pd-* disks on Hyperdisk-only machines - Added examples/c4a-machine with complete C4A configuration - Updated documentation with Hyperdisk support section and FAQ Signed-off-by: rluisr <[email protected]>
Signed-off-by: rluisr <[email protected]>
Signed-off-by: rluisr <[email protected]>
Signed-off-by: rluisr <[email protected]>
d53ad87 to
6b0972f
Compare
Author
|
hi @Zurvarian, can you take a look? Let me know if you have any suggestions and whether this works for you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

what
hyperdisk-balancedboot_disk_typevariable to allow explicit override of boot disk typepersistent_disk_typeto prevent usingpd-*disk types with Hyperdisk-only machinesmachine_typeto prevent using ARM64 machine types (C4A, A4X, A4, T2A, T2D)why
references
pd-standard,pd-ssd,pd-balanced)