fix(login): make username and password required

[shadowbas]

Remove the empty redundant ngModel directive.

[castaway]

It looks like validation is supported in template-driven forms, and as we don't need to capture valuechanges or similar, I think this would be better in KISS style by just adding "required" to the input fields, rather than switching to Reactive forms: https://v16.angular.io/guide/form-validation

[shadowbas]

It looks like validation is supported in template-driven forms, and as we don't need to capture valuechanges or similar, I think this would be better in KISS style by just adding "required" to the input fields, rather than switching to Reactive forms: https://v16.angular.io/guide/form-validation

@castaway, Required using angular material does not behave like native inputs. It behaves as if required is not defined.

[shadowbas]

I guess, what I said is not completely correct. The main issue really is that one has to render the errors themselves using mat-error component. The reactive approach has the rendering of errors baked in.

[shadowbas]

@castaway , you are correct that template driven forms offer the ability to perform required validation. I read that forms with validation should use reactive forms and went with that.

[castaway]

lgtm

[shadowbas]

@castaway, rebased and ready to merge.