refactor: Update CI workflow to support runpod>= versioning #5
+19
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Update grep pattern from runpod~= to runpod>= - Replace major.minor range logic with semantic version comparison - Add validation for current_version extraction - Update sed replacement to maintain >= operator - Workflow now triggers on any version increase (patch, minor, major) Previously, the workflow only updated for major.minor changes due to ~= (compatible release) constraint. Now with >=, all new releases are honored.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CI workflow to accommodate semantic versioning changes for the runpod dependency, switching from a compatible release constraint (~=) to a minimum version constraint (>=). This allows the workflow to trigger updates for any version increase (patch, minor, or major) rather than only major.minor changes.
Key Changes:
- Updated version constraint from
~=to>=in requirements.txt - Replaced major.minor range comparison with full semantic version comparison using
sort -V - Added validation to ensure current version extraction succeeds before proceeding
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| builder/requirements.txt | Updated runpod version constraint from ~=1.7.0 to >=1.8.0 |
| .github/workflows/CI-runpod_dep.yml | Refactored version comparison logic to support >= operator and validate version extraction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Previously, the workflow only updated for major.minor changes due to ~= (compatible release) constraint. Now with >=, all new releases are honored.