refactor: Update CI workflow to support runpod>= versioning #241
+27
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Update grep pattern from runpod~= to runpod>= - Replace major.minor range logic with semantic version comparison - Add validation for current_version extraction - Update sed replacement to maintain >= operator - Workflow now triggers on any version increase (patch, minor, major) Previously, the workflow only updated for major.minor changes due to ~= (compatible release) constraint. Now with >=, all new releases are honored.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CI workflow to support semantic version comparison for runpod dependencies using the >= operator instead of ~=, enabling updates for all version types (major, minor, and patch) rather than just major.minor changes.
Key changes:
- Switch from compatible release constraint (
~=) to minimum version constraint (>=) - Replace string-based major.minor comparison with semantic version comparison using
sort -V - Add validation for current version extraction from requirements.txt
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| builder/requirements.txt | Update runpod version constraint from ~=1.7.7 to >=1.8.0 |
| .github/workflows/CI-runpod_dep.yml | Refactor version comparison logic to use semantic versioning and add current version validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address Copilot review feedback:
- Fix grep pattern to support >= operator using [>~=]+ instead of [~=]{1,2}
- Restore PyPI fetch for new_version variable that was accidentally removed
- Add validation for new_version extraction
- Restore sed command to update requirements.txt with >= operator
- Restore PR creation step to automate version update PRs
- Improve comment clarity for semantic version comparison
The workflow now correctly fetches, compares, and updates runpod versions
using >= constraint for all semantic version types (major, minor, patch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Previously, the workflow only updated for major.minor changes due to ~= (compatible release) constraint. Now with >=, all new releases are honored.