x/printer: serialize writes and reuse buffer #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`io.Writer` implementations are not guaranteed to support writes from multiple concurrent goroutines. However, users of `kawa.Destination` implicitly assume that `Send` is safe to call concurrently. (I'm working to document that assumption.) I added a channel-based mutex to serialize the writes (and allow cancellation), plus have a reusable buffer so that each batch can be performed in a single `Write`. (This lowers syscall overhead.) Add doc comments for exported symbols.
Added tests to isolate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.Writerimplementations are not guaranteed to support writes from multiple concurrent goroutines. However, users ofkawa.Destinationimplicitly assume thatSendis safe to call concurrently. (I'm working to document that assumption.) I added a channel-based mutex to serialize the writes (and allow cancellation), plus have a reusable buffer so that each batch can be performed in a singleWrite. (This lowers syscall overhead.)Add doc comments for exported symbols.