internal/sources/windows: copy from kawa #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process, I made some improvements: - `syscall.NewCallback` is a limited resource, but it gets called on every subscription. For event log-heavy configurations, this could crash reveald. To address this, I create a single callback at package initialization. - Rather than make the entire event log package Windows-only, I stub out the relevant system calls on non-Windows platforms. This allows compiling the source files and API on all platforms, regardless of support. - I discovered that slow receivers can cause events to be dropped. I introduced an optional buffer to the channel to handle bursts of events. A small buffer is added by default. - To ensure this source works, I added a simple end-to-end test. Updates runreveal/kawa#61
abraithwaite
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Thank you for finding the little issues with this package! Really appreciate that and adding a test for it.
I kindly request that we return to the Runner pattern though. I know can be a bit awkward to use at first but maintaining consistency is important for us. I can help with any testing issues you've run into if you can show me an example of where it fell short. :-)
|
Done. PTAL |
abraithwaite
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process, I made some improvements:
syscall.NewCallbackis a limited resource, but it gets called on every subscription. For event log-heavy configurations, this could crash reveald. To address this, I create a single callback at package initialization.Updates runreveal/kawa#61