Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proving scheme organisation #3

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

Proving scheme organisation #3

wants to merge 29 commits into from

Conversation

erikareale
Copy link

@erikareale erikareale commented Jul 18, 2023 •
edited
Loading

What's done

  • organise the Proving Scheme as a generic type that can be implemented by protocols grouped in folders
  • right now provide the implementation of the Bulletproof proving scheme
  • rebase with dev

What's to do

  • choose one trait Committer or ProvingScheme
  • implement prove merging
  • optimise the management of generators
  • common strategy of error handling

@erikareale
feat: provide polynomial utils
be1fd42
@erikareale
feat: skeleton of Bulletproof proving scheme
1aa86a7
@erikareale
fix: solved todos for lagrange formula and middle splitting
c420753
@erikareale
feat: extend ProvingScheme with utility methods and prove, verify i…
96b3fe8 
…mplementation
@erikareale
feat & fix: make generators global and correct logic relationship bet…
c83a650 
…ween commit-prove-verify
@erikareale
test: add test for evaluating the polynomial's and
7126fe5 
prove-verification flow
@erikareale
refactor: move generic types of trait as internal types
c753309
@erikareale
fix: correct computation of Q point including the inner product
37c7c9e
@erikareale
docs: add code and doc comments
57c0255
@erikareale
feat: implement increasing of gens
83631ea
@erikareale
feat: provide polynomial utils
af281f0
@erikareale
feat: skeleton of Bulletproof proving scheme
71c6cc9
@erikareale
fix: solved todos for lagrange formula and middle splitting
c13a8b2
@erikareale
feat: extend ProvingScheme with utility methods and prove, verify i…
77b0b53 
…mplementation
@erikareale
feat & fix: make generators global and correct logic relationship bet…
05848ee 
…ween commit-prove-verify
@erikareale
test: add test for evaluating the polynomial's and
97c8c3a 
prove-verification flow
@erikareale
refactor: move generic types of trait as internal types
159b70a
@erikareale
fix: correct computation of Q point including the inner product
01adc24
@erikareale
docs: add code and doc comments
ae3146b
@erikareale
feat: implement increasing of gens
a4e0227
@erikareale
doc: add todo specifying to choose one of the proving scheme's traits
e2f812a
@erikareale
Merge branch 'proving_scheme_organisation' of github.com:runtime-mach…
6eed4d2 
…ines/verkle-tree-rust into proving_scheme_organisation
ripa1995
ripa1995 reviewed Jul 18, 2023
View reviewed changes
src/proving_schemes/bulletproof/mod.rs Outdated Show resolved Hide resolved
src/proving_schemes/bulletproof/mod.rs Outdated Show resolved Hide resolved
src/proving_schemes/bulletproof/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripa1995 ripa1995 ripa1995 left review comments

@bonomip bonomip Awaiting requested review from bonomip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikareale @ripa1995