Integrate summaries of opcode automatically into the evm semantics #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
reviewed
Mar 4, 2025
Stevengre
force-pushed
the
jh/summary-integration
branch
from
f6646f4 to
82c51a7
Compare
|
Change files:
|
|
Should I provide tests to test the summary rules? Just like what we've done for the exising one, showing that the summary rules do the same as the previous ones. Or should we verify if the rules are correct or not? Should we provide these tests inside of the CI? Should delete the previous CI test for the summarzation after we've provided the one for testing/verifying the summarization result. |
|
Or maybe I can verify the correctness of these summary rules and migrate all the tests through the normal semantics to the summary ones? |
Stevengre
force-pushed
the
jh/summary-integration
branch
from
f96c3c7 to
0e86747
Compare
tothtamas28
reviewed
Mar 11, 2025
Comment on lines
+19
to
+24
| module EDSL-SUMMARY | ||
| imports EDSL-PURE | ||
| imports SUMMARY | ||
| endmodule | ||
|
|
||
| module EDSL-SUMMARIZE |
There was a problem hiding this comment.
What's the difference between these two modules?
tothtamas28
reviewed
Mar 12, 2025
| @@ -643,13 +698,12 @@ def batch_summarize(num_processes: int = 4) -> None: | |||
| num_processes: Number of parallel processes to use. Defaults to 4. | |||
| """ | |||
|
|
|||
| opcodes_to_process = OPCODES.keys() | |||
| OPCODES.keys() | |||
There was a problem hiding this comment.
Suggested change
| OPCODES.keys() |
kevm-pyk/src/kevm_pyk/summarizer.py
Outdated
Comment on lines
609
to
610
| def _remove_inf_gas(res_line: str) -> str: | ||
| return re.sub(r'#gas (\([^)]*\))', r'\1', res_line) |
There was a problem hiding this comment.
Would it be possible to do these transformations directly on the KRule produced by summarization?
Stevengre
force-pushed
the
jh/summary-integration
branch
from
ce061ca to
12fe54e
Compare
…ule. This commit includes build_spec and explore to constrcut a specification for all instructions and explore it.
…ding to KEVMSemantics
- Add 'requires "../evm.md"' at the start of the module - Insert 'imports EVM' after the module declaration - Simplify module writing logic to handle imports and requires
- Rename 'summary' target to 'summarize' in kdist plugin - Add new LLVM and Haskell summary targets - Modify driver.md and edsl.md to support summary module imports - Update summarizer to generate more robust summary files - Add summary.k file to aggregate individual summary modules - Implement text processing for summary file generation (remove inf gas, clean variable names)
- Include requires and imports for a wide range of EVM opcode summary specifications - Expand the SUMMARY module to cover numerous opcodes from basic arithmetic to memory and storage operations - Ensure complete coverage of EVM instruction summaries in the module
- Remove unnecessary account constraints and DotAccountVar references - Modify summarizer to handle complex regex replacements for cleaner spec files - Update opcode symbol parsing to handle parentheses in opcode names - Remove redundant requires and andBool conditions in summary specs - Rename an undefined opcode summary file to fix import syntax
…constraints - Modify summarizer to comment out complex regex replacements - Update summary files to use simpler account representation - Remove parenthesized account and DotAccountVar references - Restore _use_legal_remainder function with commented-out complex logic
- Update summary files for numerous EVM opcodes - Modify basic block rules in summary specification files - Systematically process and generate summary files for various EVM instructions
- Add function to replace LHS function with assignment in summary-balance specs - Modify account ID representation in balance summary files - Update regex transformation to simplify account ID constraints
- Reduce summarization test timeout from 360 to 150 seconds - Remove duplicate method in KEVM class - Update poetry.lock dependencies and extras - Modify batch summarization processing logic - Clean up regex transformations in summary specification generation
- Modify Poetry lock file to add platform-specific extras and dependency constraints - Update Poetry version from 2.0.1 to 2.1.1 - Add conditional dependencies for different Python implementations and versions - Refine package extras with more precise platform and version requirements
- Upgrade Hypothesis from 6.125.2 to 6.127.9 - Update setuptools from 75.8.0 to 75.8.2 - Add watchdog dependency to Hypothesis extras - Refresh package hashes and version constraints
- Modify account ID replacement logic in summarizer - Remove commented-out explanatory notes - Streamline regex pattern for summary-balance specifications
- Reformat target argument definition for better readability - Maintain existing target choices for KEVM CLI
…nd summaried one.
Stevengre
force-pushed
the
jh/summary-integration
branch
from
30a0dcc to
3423f02
Compare
- Reduced timeout for the 'Summarization' test suite from 150 to 30 seconds. - Updated dependencies: filelock to version 3.18.0, hypothesis to version 6.129.1, and setuptools to version 76.0.0 in poetry.lock.
…from summarizer and summary.k files to address potential issues with log2 calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2676, integrating all the summaries into the evm semantics. Specifically, it includes the following changes: