Add error handling for stderr in interpret function #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Stevengre
commented
Mar 14, 2025
Stevengre
commented
- Raise an exception if there is any output in stderr after processing the command.
- This change ensures that errors are caught and handled appropriately during interpretation.
- Raise an exception if there is any output in stderr after processing the command. - This change ensures that errors are caught and handled appropriately during interpretation.
tothtamas28
reviewed
Mar 14, 2025
| @@ -21,6 +21,9 @@ def interpret(gst_data: Any, schedule: str, mode: str, chainid: int, usegas: boo | |||
| if check: | |||
| proc_res.check_returncode() | |||
|
|
|||
| if len(proc_res.stderr) > 0: | |||
| raise Exception(proc_res.stderr) | |||
There was a problem hiding this comment.
This seems a bit convoluted. If check is True, then this code I think is not reachable. Otherwise, you do not want an exception to be raised.
There was a problem hiding this comment.
The call to run_process_2 in _interpret should probably be replaced by llvm_interpret from pyk.ktool.krun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.