expectRevert causing early failure when cheatcodes are called before the reverting call

[anvacaru]

When using vm.expectRevert() with cheatcodes like vm.addr() or makeAddr(), Kontrol would incorrectly trigger the revert check on the cheatcode call, leading to tests failing with EVMC_REVERT instead of waiting for the actual reverting call.

    function test_expectRevert_whenDelegating() public {
     ....
        vm.expectRevert();
        cut.delegate(address(vm.addr(1));
     ...
    }

For example, in cases where a function is invoked after an expectRevert, the test would fail prematurely because of the vm.addr() call that causes the #checkRevert mechanism to intervene on the successful vm.addr() call.

The root cause was the foundry.set.expectrevert rules inserting #checkRevert for every opcode call, including cheatcodes, contrary to Foundry’s specification.
OTOH, the overly aggressive cheatcode.call.ignoreCalls rule prevented proper execution and return values of cheatcodes.

The solution involved removing the cheatcode.call.ignoreCalls rule to allow normal execution of cheatcodes and adding guards to the foundry.set.expectrevert rules to skip adding the #checkRevert for calls to the FoundryCheatCode contract address (vm).
This ensures that cheatcodes execute normally during expectRevert, only actual contract calls are monitored, and tests remain consistent with Foundry behavior.

[anvacaru]

Closing as duplicate of #1012.