Graph improvements #72
Merged
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrepta
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
LGTM.
The MirConst from const ?_u32 appears to have a eval_target_usize method which might return the constant as a u64. I tried to add it in real quick but got a compiler panic, "expected int of size 8, but got size 4". It might be pretty sensitive to how it gets called, but I didn't mess with it any further.
jberthold
approved these changes
May 1, 2025
Co-authored-by: Jost Berthold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some readability issues are fixed in this PR:
Derefprojections are now wrapped in parenthesis e.g.(*4)::", e.g.const :: u32is nowconst ?_u32, andconst :: std::ops::ExitCodeis nowconst std::ops::ExitCode. I do not like that there is "?" but I couldn't see a fast way to deal with the bytes in theAllocation, does anyone know how to parse that into the integer?Rvalue::AddressOfe.g.&Mut (*3)is now&raw mut (*3), which is less likely to be confused with a mutable borrow&mut (*3)