extend volume settings for runwhenlocal and fix value in runner (#20)

Co-authored-by: stewartshea <>
runwhen-contrib · May 10, 2024 · 593fca6 · 593fca6
1 parent 866a062
commit 593fca6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/charts/runwhen-local/Chart.yaml b/charts/runwhen-local/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: runwhen-local
 description: A Helm chart RunWhen Local - A community powered troubleshooting cheat sheet
 type: application
-version: 0.1.10
+version: 0.1.11
 appVersion: "0.5.12"
 icon: https://storage.googleapis.com/runwhen-nonprod-shared-images/icons/runwhen_icon.png
 dependencies:

diff --git a/charts/runwhen-local/templates/local-deployment.yaml b/charts/runwhen-local/templates/local-deployment.yaml
@@ -108,6 +108,9 @@ spec:
             mountPath: "/shared/uploadInfo.yaml"
             subPath: "uploadInfo.yaml"
           {{- end }}
+          {{- with .Values.runwhenLocal.volumeMounts }}
+          {{- toYaml . | nindent 10 }}
+          {{- end }}
       volumes:
       - name: shared-volume
         emptyDir: {}
@@ -131,6 +134,9 @@ spec:
         configMap:
           name: {{ if .Values.runwhenLocal.workspaceInfo.useExistingConfigMap }}{{ .Values.runwhenLocal.workspaceInfo.existingConfigMapName }}{{ else }}{{ .Values.runwhenLocal.workspaceInfo.configMap.name }}{{ end }}
       {{- with .Values.nodeSelector }}
+      {{ with .Values.runwhenLocal.volumes }}
+        {{- toYaml . | nindent 8 }}
+      {{- end }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}
       {{- end }}

diff --git a/charts/runwhen-local/templates/runner-deployment.yaml b/charts/runwhen-local/templates/runner-deployment.yaml
@@ -20,7 +20,7 @@ spec:
     metadata:
       labels:
         app: runner
-      {{- with .Values.runwhenLocal.podAnnotations }}
+      {{- with .Values.podAnnotations }}
       annotations:
         {{- toYaml . | nindent 8 }}
       {{- end }}
@@ -103,7 +103,7 @@ spec:
       - name: runner-config-volume
         configMap:
           name: {{ .Values.runner.configMap.name }}
-      {{ with .Values.volumes }}
+      {{ with .Values.runner.volumes }}
         {{- toYaml . | nindent 8 }}
       {{- end }}
 {{- end }}
diff --git a/charts/runwhen-local/values.yaml b/charts/runwhen-local/values.yaml
@@ -57,6 +57,12 @@ runwhenLocal:
     # Overrides the image tag whose default is the chart appVersion.
     tag: "latest"
 
+  # Extra volumes for the runwhen-local container
+  volumes: {}
+
+  # Extra volume mounts for the  runwhen-local container
+  volumeMounts: {}
+
   serviceAccount:
     # Specifies whether a service account should be created
     create: true