wyhash fv4.1 #277
Closed
wyhash fv4.1 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But that's still the bad wyhash version, which is slower and as has more bad seeds. |
|
4.1 has bug due to make_secret function which came from someone's PR. |
Didn't know it's already changed.
After taking a look I conclude the difference is in secret only. Is it that much of a difference? |
|
yes. V4.1 seeds are generated by a "simplified" make_secret function. This function is from someone's early PR, and I didn't notice till now that he removed an essential code line (to make sure secrets are prime numbers). Thus your PR awake me to fixed this bug :-) |
|
I"m working on the 4.2 update instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V4.1 to make it more stream friendly
Change is cosmetic from a tester point of view. Just so you know.