Skip to content

Adding requirement for iOS 11.0.1 or newer for property biometryType #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding requirement for iOS 11.0.1 or newer for property biometryType #15

wants to merge 1 commit into from

Conversation

karlisl
Copy link

@karlisl karlisl commented Feb 28, 2018 •
edited
Loading

Fix for "Property biometryType is only available on iOS 11.0.1 or newer". Library won't compile under iOS 11.3 SDK.

... when checking for biometryType availability, please check against iOS 11.0.1, because iOS 11.0 didn’t contain the property at all, so you’d end up crashing on devices that still run the initial 11.0 release. The annotation was fixed in 11.2 or 11.3.

https://openradar.appspot.com/36064151
https://github.com/mshibanami/BiometryTypeBugWorkaround

hemangshah
hemangshah suggested changes Sep 23, 2018
View reviewed changes
Copy link

@hemangshah hemangshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too broad solution to this problem, looking forward to see something more better way than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hemangshah hemangshah hemangshah requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karlisl @hemangshah