-
Notifications
You must be signed in to change notification settings - Fork 40
Release tracking PR: jsonrpc v0.19.0
#408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Reviewed 52c02b3, all good. |
52c02b3 to
53ba2b2
Compare
Currently lists the repository name from before we did the `corepc` rename. Note this was never released, as such crates.io still points at Andrew's repo.
When we moved this crate from Andrew's repo somehow I forgot to bring over the `CHANGELOG.md` file. Copy it from the original repo (now archived). https://github.com/apoelstra/rust-jsonrpc/blob/master/CHANGELOG.md
In preparation for release bump the version number, add a changelog entry, and update the lock files.
53ba2b2 to
d3e73a7
Compare
|
@apoelstra do you want to do the release of |
jamillambert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d3e73a7
|
@apoelstra we want to do a new release of all these crates with Core v30 support soon. Sorry to break your balls but can you take a few minutes to think about this one please? |
|
Breaking your balls just to bubble this PR a bit higher up your priority list please @apoelstra. With the current state of We have two choices:
Its not super urgent but if we can I'd prefer to do (2). |
Do a couple of minor cleanups then do the release patch - version bump, changelog, and lock files.