Upgrade bitcoin version and remove lightning#40
Open
jrawsthorne wants to merge 4 commits intorust-bitcoin:masterfrom
Open
Upgrade bitcoin version and remove lightning#40jrawsthorne wants to merge 4 commits intorust-bitcoin:masterfrom
jrawsthorne wants to merge 4 commits intorust-bitcoin:masterfrom
Conversation
erasmospunk
suggested changes
Aug 7, 2020
Contributor
erasmospunk
left a comment
erasmospunk
left a comment
There was a problem hiding this comment.
LGTM apart the API change.
| bitcoin = { version= "0.23", features=["use-serde"]} | ||
| bitcoin_hashes = "0.7" | ||
| hammersbald = { version= "2.4", features=["bitcoin_support"]} | ||
| hammersbald = { git= "https://github.com/jrawsthorne/hammersbald.git", branch="upgrade-bitcoin", features=["bitcoin_support"]} |
Contributor
There was a problem hiding this comment.
This should change once the upgrade-bitcoin branch is merged in the hammersbald repo.
Contributor
Author
There was a problem hiding this comment.
Yeah I'll change it when that gets merged. Wanted to make sure tests passed
src/chaindb.rs
Outdated
| if let Some((cached, _, _)) = self.headercache.add_header(&genesis)? { | ||
| info!("initialized with genesis header {}", genesis.bitcoin_hash()); | ||
| self.db.put_hash_keyed(&cached.stored)?; | ||
| self.db.put_hash_keyed(&cached.bitcoin_hash().as_hash(), &cached.stored)?; |
Contributor
There was a problem hiding this comment.
Can we preserve the API here?
Collaborator
|
I built on this to make #47, could you guys perhaps review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Depends on rust-bitcoin/hammersbald#13