Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese language support #53

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

flemosr
Copy link
Contributor

@flemosr flemosr commented Oct 13, 2023

This PR adds Portuguese language support, using the wordlist specified in the BIP-39 standard.

Enable the "rand" feature by default in the dev-dependencies, in order to run
the benches.
@flemosr
Copy link
Contributor Author

flemosr commented Oct 13, 2023

In the first commit, I enabled the "rand" feature by default in the dev-dependencies, in order to run the benches. Not sure if I missed something that would make this unnecessary.

@tcharding
Copy link
Member

utACK e0102ba

I thought mostly about the toml changes in the first patch, looks correct to me.

@stevenroose
Copy link
Collaborator

This is very cool! Thanks!

Copy link
Collaborator

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@stevenroose stevenroose merged commit 405b290 into rust-bitcoin:master Oct 19, 2023
6 checks passed
@stevenroose
Copy link
Collaborator

Release PR: #54

@stevenroose
Copy link
Collaborator

Inspired me to add multi-language support to hal: stevenroose/hal#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants