Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use specific revision of maintainer-tools #720

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

tcharding
Copy link
Member

We don't want to pull the maintainer tools repo from master otherwise we cannot patch it, we should use a specific revision.

This was an oversite in the original work when introducing the maintainer tools run_task script.

Use commit:

b2ac115 Merge rust-bitcoin/rust-bitcoin-maintainer-tools#4: Add CI shell scripts

We don't want to pull the maintainer tools repo from master otherwise we
cannot patch it, we should use a specific revision.

This was an oversite in the original work when introducing the
maintainer tools `run_task` script.

Use commit:

b2ac115 Merge rust-bitcoin/rust-bitcoin-maintainer-tools#4: Add CI shell scripts
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dc7ed26

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dc7ed26 successfully ran local tests; though once it stabilizes a bit we may want to start adding tags to maintainer-tools (maybe with just the date) to make it more visually obvious when we get out of date

@apoelstra apoelstra merged commit b729fdd into rust-bitcoin:master Aug 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants