Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MaxBareScriptSizeExceeded err for bare consensus check #756

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat: add MaxBareScriptSizeExceeded err for bare consensus check #756

merged 1 commit into from
Oct 17, 2024

Conversation

ChrisCho-H
Copy link
Contributor

@ChrisCho-H ChrisCho-H commented Oct 16, 2024 •
edited
Loading

BareCtx consensus validity check returns MaxWitnessScriptSizeExceeded err when exceeding script size limit, which is wrong and confusing. Adding MaxBareScriptSizeExceeded and using it instead can clearly give a correct message on compile error.

apoelstra
apoelstra approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 834bd3d; successfully ran local tests; Yeah, this seems like a good idea

@apoelstra apoelstra merged commit 7ae7596 into rust-bitcoin:master Oct 17, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisCho-H @apoelstra