Make xpub and xpriv identifiers match rust-bitcoin #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently in `rust-bitcoin` we agreed that 'xpub' and 'xpriv' are well known terms in the Bitcoin vernacular so, being "words" should be written as `Xpub` and `Xpriv` when translated to Rust identifiers. Make the descriptor key identifiers match `rust-bitcoin`.
|
Jeeebus, I didn't realize that in descriptors we use |
|
This isn't a descriptor thing. |
|
I don't mind changing the capitalization here. But FWIW I don't think anybody uses the rust-bitcoin types if they have access to the rust-minscript types. So it's not the end of the world if they're inconsistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently in
rust-bitcoinwe agreed that 'xpub' and 'xpriv' are well known terms in the Bitcoin vernacular so, being "words" should be written asXpubandXprivwhen translated to Rust identifiers.Make the descriptor key identifiers match
rust-bitcoin.