fix: ensure consistent bash command output across terminal environments #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output from `spawn_bash` was inconsistent depending on the terminal
environment where the process was spawned. In tmux and other advanced
terminals, the output included ANSI control sequences for features like
bracketed paste mode, causing test failures and unreliable behavior.
Set TERM="" when spawning bash to force a dumb terminal mode, ensuring
clean, consistent output regardless of the parent terminal environment.
Example error:
```
thread 'session::tests::test_bash' panicked at src/session.rs:542:9:
assertion `left == right` failed
left: "/tmp\r\n"
right: "\u{1b}[?2004l\r\r\n/tmp\r\n\u{1b}[?2004h"
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output from
spawn_bashwas inconsistent depending on the terminal environment where the process was spawned. In tmux and other advanced terminals, the output included ANSI control sequences for features like bracketed paste mode, causing test failures and unreliable behavior.Set TERM="" when spawning bash to force a dumb terminal mode, ensuring clean, consistent output regardless of the parent terminal environment.
Example error: