Skip to content

Enable resolver ver2 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2025
Merged

Enable resolver ver2 #224

merged 3 commits into from
Mar 16, 2025

Conversation

akru
Copy link
Contributor

@akru akru commented Mar 11, 2025

As maybe-async-cfg crate docs suggested

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

maybe_async_cfg crate suggested to add resolver v2 directive. For me it fixes compilation issues.

RECOMMENDATION: Enable resolver ver2 in your crate, which is introduced in Rust 1.51. If not, two crates in dependency with conflict version (one async and another blocking) can fail compilation.

As maybe-async-cfg crate docs suggested
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Could you add a short entry to the changelog explaining this?

@akru
Copy link
Contributor Author

akru commented Mar 16, 2025

@eldruin Sure, added note into CHANGELOG.

@akru
Copy link
Contributor Author

akru commented Mar 16, 2025

@eldruin may be problem isn't in resolver btw; this problem I tried to solve: #219, anyway, ver2 is recommended, why not use it

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@eldruin eldruin merged commit 71aa641 into rust-embedded-community:master Mar 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants