Don't trash the LR returned from _undefined_handler. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modifies the undef-exception test to make sure we can actually recover from an undef exception. And updates the abt-exception test to also check returning, and dealing with both A32 and T32 modes.
thejpster
force-pushed
the
fix-exception-return
branch
from
e85d1f2 to
4c451f6
Compare
< DFAR (Faulting Address Register): Dfar(39853)
---
> DFAR (Faulting Address Register): Dfar(39685)
12c12
< DFAR (Faulting Address Register): Dfar(39853)
---
> DFAR (Faulting Address Register): Dfar(39685)OK - we shouldn't print the address of linker allocated variables because they can move. |
The linker doesn't give a consistent address for the value used for the abort test, so check the address but don't print the address.
robamu
reviewed
Apr 23, 2025
cortex-r-rt/src/lib.rs
Outdated
| @@ -487,6 +483,8 @@ core::arch::global_asm!( | |||
| "#, | |||
| restore_context!(), | |||
| r#" | |||
| // overwrite the saved LR with the adjusted one | |||
There was a problem hiding this comment.
Am I understanding it correctly that the LR returned by the C/Rust handler is stored here, which does not necessarily have to be the adjusted LR?
Maybe "overwrite the saved LR with the one returned by the C handler" is better?
There was a problem hiding this comment.
yeah, fair, the handler could have but might not have adjusted the value
robamu
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also modifies the undef-exception test to make sure we can actually recover from an undef exception. And updates the abt-exception test to also check returning, and dealing with both A32 and T32 modes.