Skip to content

Removed mutable borrow in readonly generic timer methods #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Removed mutable borrow in readonly generic timer methods #31

merged 1 commit into from
Apr 23, 2025

Conversation

emanuelemessina
Copy link
Contributor

Namely:

  • counter
  • counter_compare

Also, enforced lf ending on shell scripts via gitattributes.

@emanuelemessina
Removed mutable borrow in readonly generic timer methods
ccd45a4 
Namely:
- counter
- counter_compare

Also, enforced lf ending on shell scripts via gitattributes.
jonathanpallant
jonathanpallant approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@jonathanpallant jonathanpallant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems reasonable to me. These registers are pure (as in, reads have no side effects).

@jonathanpallant jonathanpallant merged commit 6a8aefe into rust-embedded:main Apr 23, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpallant jonathanpallant jonathanpallant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emanuelemessina @jonathanpallant