Relax indexmap PartialEq bounds so value doesn't need to be Eq #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for something that didn't work before? |
reitermarkus
reviewed
Apr 5, 2025
reitermarkus
previously approved these changes
Apr 5, 2025
reitermarkus
force-pushed
the
indexmap-partialeq
branch
from
3e117e6 to
ac3541c
Compare
reitermarkus
previously approved these changes
Apr 5, 2025
reitermarkus
force-pushed
the
indexmap-partialeq
branch
from
ac3541c to
80bdf31
Compare
Co-authored-by: Markus Reiter <[email protected]>
reitermarkus
force-pushed
the
indexmap-partialeq
branch
from
80bdf31 to
1052f4d
Compare
reitermarkus
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old bounds were unnecessarily strict. This PR relaxes the
V: Eqbound toV: PartialEq.