Add CString cont.
#549
Merged
Add CString cont.
#549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviqqe
commented
Apr 7, 2025
raviqqe
commented
Apr 7, 2025
src/c_string.rs
Outdated
| /// | ||
| /// assert_eq!(cstr.to_str(), Ok("hey there")); | ||
| /// ``` | ||
| pub fn push_bytes(&mut self, bytes: &[u8]) -> Result<(), CapacityError> { |
There was a problem hiding this comment.
Should we rename this extend_from_bytes or extend_from_slice?
There was a problem hiding this comment.
I renamed it extend_from_bytes for now. extend_from_slice is a bit ambiguous because it might mean either byte or CStr slices.
raviqqe
commented
Apr 7, 2025
vrmiguel
reviewed
Apr 8, 2025
reitermarkus
requested changes
Apr 10, 2025
Co-authored-by: Markus Reiter <me@reitermark.us>
Co-authored-by: Markus Reiter <me@reitermark.us>
Co-authored-by: Markus Reiter <me@reitermark.us>
Co-authored-by: Markus Reiter <me@reitermark.us>
reitermarkus
approved these changes
Apr 15, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continued work of #342, the heapless implementation of
alloc::ffi::CString. Credits to @vrmiguel.Closes #330.
Notable changes from the previous PR
Deref<Target = CStr>forCString.Default,AsRef,Borrow,PartialEq,Eq,PartialOrd, andOrdlenandas_str_uncheckedassociated functions that should be implemented in the upstream ofcore::ffi::CStr.push_bytesassociated functionextend_from_bytes.heapless::Vec.Future work
heapless::StringinteroperabilityCString::into_stringheapless::VecinteroperabilityCString::from_vec_with_nulCString::into_bytesCString::into_bytes_with_nul