Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asm_const attribute because it is no longer required #220

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChocolateLoverRaj
Copy link

@ChocolateLoverRaj ChocolateLoverRaj commented Oct 18, 2024

Description

I got this error:

error: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable
   --> src/main.rs:109:12
    |
109 | #![feature(asm_const)]
    |            ^^^^^^^^^
    |
    = note: `-D stable-features` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(stable_features)]`

so I removed the line and created this PR. I tested it in QEMU and it worked. Real HW raspberry Pi is not applicable since it's just tutorial 2.

Pre-commit steps

  • Tested on QEMU and real HW Rasperry Pi.
    • Not needed if it is just a README change or similar.
  • Ran ./contributor_setup.sh followed by ./devtool ready_for_publish
    • You'll need Ruby with Bundler and NPM installed locally.
    • If no Rust-related files were changed, ./devtool ready_for_publish_no_rust can be used instead (faster).
    • This step is optional, but much appreciated if done.

@jannic
Copy link
Member

jannic commented Oct 18, 2024

If we rely on recent features, we probably need to update https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/rust-toolchain.toml as well.

@ChocolateLoverRaj
Copy link
Author

I updated the toolchain. As I go through the tutorials there are more things that need to be changed to work with the latest Rust version. Should I make a PR that updates all tutorials to work? Is there a shortcut for having to modify changes from 03 that also need to be changed from 04 to 20?

@BartMassey
Copy link
Member

I would suggest that you fork this tutorial and work on a branch, fixing things as you go with one commit per fix. Then submit a PR to bring your branch to mainline and we can discuss it.

@ChocolateLoverRaj ChocolateLoverRaj marked this pull request as draft November 7, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants