Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 19, 2026

By defaut, it will now include the messages of all squashed commits. The commit message can now be overwritten using @bors squash msg="Foo bar".

@Kobzol Kobzol enabled auto-merge January 19, 2026 08:34
@Kobzol Kobzol disabled auto-merge January 19, 2026 08:36
let b = bytes[i];

if in_quotes {
if b == b'"' {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this support escaping quotes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be done as a follow-up, but I'd wait for a use-case 😆 It also can't deal with multi-line commit messages, backticks, etc., so it is limited anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, you're depending on serde_json anyway, why not use that to parse the string? something like:

// Check if value starts with quote
if i < len && bytes[i] == b'"' {
    let mut de = serde_json::de::Deserializer::from_slice(&bytes[i..]).into_iter();
    match String::deserialize(&mut de) {
        Ok(value) => {
            i += de.byte_offset();
            // handle string
        }
        Err(e) => {
            // handle error
        }
    }
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I tried it, but sadly it looks like pulldown_cmark removes the quote escapes :( The interaction between our parser and Markdown is a bit complicated (#430 (comment)).

@Kobzol Kobzol enabled auto-merge January 19, 2026 08:43
@Kobzol Kobzol added this pull request to the merge queue Jan 19, 2026
Merged via the queue into rust-lang:main with commit dcb6580 Jan 19, 2026
3 checks passed
@Kobzol Kobzol deleted the squash-message branch January 19, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants