Closed
Conversation
cc generates an archive, so -static doesn't make sense
thomcc
reviewed
Jun 8, 2024
Member
thomcc
left a comment
There was a problem hiding this comment.
On the one hand, yeah this is (IIUC) basically a linker flag and we don't invoke the linker. On the other hand, I'm 80% sure I've had to use it before.
Is there something that brought about wanting to make this change?
Co-authored-by: Thom Chiovoloni <thom@shift.click>
Contributor
Author
|
It's the same motivation with #1077 , cc doesn't do linking by itself, users using cc for linking would need to convert to Tools to command and manually do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc only compiles file and does not do any linking at all, so
-staticdoesn't make sense