Skip to content

Deprecate cc::Build::static_flag#1078

Closed
NobodyXu wants to merge 2 commits intomainfrom
NobodyXu-patch-2
Closed

Deprecate cc::Build::static_flag#1078
NobodyXu wants to merge 2 commits intomainfrom
NobodyXu-patch-2

Conversation

@NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Jun 2, 2024

cc only compiles file and does not do any linking at all, so -static doesn't make sense

cc generates an archive, so -static doesn't make sense
@NobodyXu NobodyXu requested a review from thomcc June 2, 2024 05:25
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, yeah this is (IIUC) basically a linker flag and we don't invoke the linker. On the other hand, I'm 80% sure I've had to use it before.

Is there something that brought about wanting to make this change?

Co-authored-by: Thom Chiovoloni <thom@shift.click>
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jun 8, 2024

It's the same motivation with #1077 , cc doesn't do linking by itself, users using cc for linking would need to convert to Tools to command and manually do that

@NobodyXu NobodyXu closed this Jul 8, 2024
@NobodyXu NobodyXu deleted the NobodyXu-patch-2 branch July 8, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants