Add generator, async tests with uninhabited saved local #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would be great if you could also update |
RalfJung
reviewed
Aug 8, 2019
| let mut fut = includes_never(false, 4); | ||
| let waker = unsafe { Waker::from_raw(RawWaker::new(ptr::null(), &RAW_WAKER)) }; | ||
| let mut context = Context::from_waker(&waker); | ||
| assert_eq!(unsafe { Pin::new_unchecked(&mut fut) }.poll(&mut context), Poll::Ready(16)); |
There was a problem hiding this comment.
Is it possible to move the common parts of these three "run an async fn" tests into a helper function?
I can also do that after landing, though.
|
I think I'll just do that in a follow-up PR. Thanks! @bors r+ |
|
📌 Commit f544721 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 9, 2019
Add generator, async tests with uninhabited saved local See discussion in rust-lang/rust#63035.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in rust-lang/rust#63035.