Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic for missing ambiguity error for impl trait #19347

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Add diagnostic for missing ambiguity error for impl trait #19347

merged 3 commits into from
Mar 25, 2025
+99 −1

Conversation

Shourya742
Copy link
Contributor

closes: #19289

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2025
@Shourya742
Copy link
Contributor Author

r? @ChayimFriedman2

Veykril
Veykril previously requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can deduplicate this a bit between validate_trait_object_ty and validate_impl_object_ty The only difference here really is the error message

@Shourya742 Shourya742 force-pushed the 2025-03-13-add-diagnostic-for-dnagling-impl-with-lifetime branch from 6fbcddf to 9acc9d6 Compare March 20, 2025 04:41
@Shourya742 Shourya742 requested a review from Veykril March 20, 2025 04:42
@Shourya742 Shourya742 force-pushed the 2025-03-13-add-diagnostic-for-dnagling-impl-with-lifetime branch 2 times, most recently from 43632cb to 02c9f51 Compare March 20, 2025 08:11
Veykril
Veykril reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code does look rather unwieldy and illegible. Let's just duplicate this after all to make it more readable, its not that much code anyways.

@Shourya742 Shourya742 force-pushed the 2025-03-13-add-diagnostic-for-dnagling-impl-with-lifetime branch from 02c9f51 to 1c62ebe Compare March 21, 2025 14:45
@Shourya742 Shourya742 force-pushed the 2025-03-13-add-diagnostic-for-dnagling-impl-with-lifetime branch from 1c62ebe to df56707 Compare March 21, 2025 15:01
@Shourya742 Shourya742 requested a review from Veykril March 21, 2025 15:01
@Veykril Veykril enabled auto-merge March 25, 2025 07:49
@Veykril Veykril dismissed their stale review March 25, 2025 07:49

stale

@Veykril Veykril added this pull request to the merge queue Mar 25, 2025
Merged via the queue into rust-lang:master with commit ed7e25a Mar 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing ambiguity error for impl trait
3 participants
@Shourya742 @Veykril @rustbot