Skip to content

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Nov 17, 2025

Fixes #21045

Example

#[no_mangle]
static lower_case: () = ();

Before this PR

non_upper_case_globals

After this PR

No diagnostics

Example
---
```rust
#[no_mangle]
static lower_case: () = ();
```

**Before this PR**

```text
non_upper_case_globals
```

**After this PR**

No diagnostics
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2025
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to resolve the subtrees thing before merging.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non_upper_case_globals lint detects no_mangle items

3 participants