Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize arc_into_inner and rc_into_inner. #109504

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Stabilize arc_into_inner and rc_into_inner. #109504

merged 1 commit into from
Mar 23, 2023

Conversation

steffahn
Copy link
Member

@steffahn steffahn commented Mar 22, 2023 •
edited
Loading

Stabilize the arc_into_inner and rc_into_inner library features and thus close #106894.

The changes in this PR also resolve the FIXMEs for adjusting the documentation upon stabilization, and I’ve additionally included some very minor documentation improvements.

@rustbot label +T-libs-api -T-libs

@steffahn
Stabilize arc_into_inner and rc_into_inner.
e8be3d2 
Includes resolving the FIXMEs in the documentation,
and some very minor documentation improvements.
@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@steffahn steffahn mentioned this pull request Mar 22, 2023
Closed
6 tasks
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 23, 2023

📌 Commit e8be3d2 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2023
@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 23, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2023
@matthiaskrgr
Rollup merge of rust-lang#109504 - steffahn:stabilize_a_rc_into_inner…
1780edf 
…, r=joshtriplett

Stabilize `arc_into_inner` and `rc_into_inner`.

Stabilize the `arc_into_inner` and `rc_into_inner` library features and thus close rust-lang#106894.

The changes in this PR also resolve the FIXMEs for adjusting the documentation upon stabilization, and I’ve additionally included some very minor documentation improvements.

`@rustbot` label +T-libs-api -T-libs
This was referenced Mar 23, 2023
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2023
@matthiaskrgr
Rollup merge of rust-lang#109504 - steffahn:stabilize_a_rc_into_inner…
9ee96c8 
…, r=joshtriplett

Stabilize `arc_into_inner` and `rc_into_inner`.

Stabilize the `arc_into_inner` and `rc_into_inner` library features and thus close rust-lang#106894.

The changes in this PR also resolve the FIXMEs for adjusting the documentation upon stabilization, and I’ve additionally included some very minor documentation improvements.

``@rustbot`` label +T-libs-api -T-libs
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2023
@bors
Auto merge of rust-lang#109517 - matthiaskrgr:rollup-m3orqzd, r=matth…
99c49d9 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108541 (Suppress `opaque_hidden_inferred_bound` for nested RPITs)
 - rust-lang#109137 (resolve: Querify most cstore access methods (subset 2))
 - rust-lang#109380 (add `known-bug` test for unsoundness issue)
 - rust-lang#109462 (Make alias-eq have a relation direction (and rename it to alias-relate))
 - rust-lang#109475 (Simpler checked shifts in MIR building)
 - rust-lang#109504 (Stabilize `arc_into_inner` and `rc_into_inner`.)
 - rust-lang#109506 (make param bound vars visibly bound vars with -Zverbose)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e445648 into rust-lang:master Mar 23, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 23, 2023
@steffahn steffahn deleted the stabilize_a_rc_into_inner branch March 23, 2023 21:56
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 24, 2023
@bors
Auto merge of rust-lang#109517 - matthiaskrgr:rollup-m3orqzd, r=matth…
f345904 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108541 (Suppress `opaque_hidden_inferred_bound` for nested RPITs)
 - rust-lang#109137 (resolve: Querify most cstore access methods (subset 2))
 - rust-lang#109380 (add `known-bug` test for unsoundness issue)
 - rust-lang#109462 (Make alias-eq have a relation direction (and rename it to alias-relate))
 - rust-lang#109475 (Simpler checked shifts in MIR building)
 - rust-lang#109504 (Stabilize `arc_into_inner` and `rc_into_inner`.)
 - rust-lang#109506 (make param bound vars visibly bound vars with -Zverbose)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@ryoqun
Copy link
Contributor

ryoqun commented Mar 29, 2023

hi, really thanks for merging this. just wondering why this pr isn't popping up at https://releases.rs/docs/1.70.0/ . maybe this pr needs relnotes label like Stabilize nonnull_slice_from_raw_parts (this is newer stabilization pr, which merged later than this, yet is shown at the releases.rs page correctly)?

@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 29, 2023
@steffahn steffahn mentioned this pull request May 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for {Arc, Rc}::into_inner
5 participants
@steffahn @rustbot @joshtriplett @bors @ryoqun