Stablize `const_binary_heap_constructor` #125211

Coekjan · 2024-05-17T13:31:13Z

This pr aims to stablize const_binary_heap_constructor.

BinaryHeap::new is able to be stablized, but BinaryHeap::new_in is not. Because the latter depends on Vec::new_in which is unstable.

The const_binary_heap_constructor feature contains the two functions, and I want to split this feature now. This pr creates const_binary_heap_new_in feature for BinaryHeap::new_in and stablizes const_binary_heap_constructor (now this original feature only contains one function).

rustbot · 2024-05-17T13:31:23Z

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

cuviper · 2024-05-17T17:45:03Z

@rustbot label -T-libs +T-libs-api

r? libs-api

jhpratt · 2024-05-20T23:30:24Z

Has FCP been completed anywhere? I don't expect this to be controversial given all similar constructors are const, but it is still required.

Coekjan · 2024-05-21T01:05:01Z

Has FCP been completed anywhere? I don't expect this to be controversial given all similar constructors are const, but it is still required.

No FCP yet. Should I do it in a new issue? Or just do it in #112353?

jhpratt · 2024-05-21T07:34:44Z

That issue is preferable to this PR, as people would already be subscribed there.

jhpratt · 2024-05-21T07:36:08Z

@rustbot claim

r=me if and when FCP passes

Coekjan · 2024-05-31T17:07:47Z

@rustbot ready

@jhpratt FCP passed

rustbot · 2024-05-31T17:07:49Z

Could not assign reviewer from: jhpratt.
User(s) jhpratt are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

dtolnay · 2024-05-31T17:47:10Z

@bors r=jhpratt,dtolnay

bors · 2024-05-31T17:47:12Z

📌 Commit ef23a5b has been approved by jhpratt,dtolnay

It is now in the queue for this repository.

bors · 2024-05-31T18:19:03Z

⌛ Testing commit ef23a5b with merge 179b6d7...

…,dtolnay Stablize `const_binary_heap_constructor` This pr aims to stablize `const_binary_heap_constructor`. `BinaryHeap::new` is able to be stablized, but `BinaryHeap::new_in` is not. Because the latter depends on `Vec::new_in` which is unstable. The `const_binary_heap_constructor` feature contains the two functions, and I want to split this feature now. This pr creates `const_binary_heap_new_in` feature for `BinaryHeap::new_in` and stablizes `const_binary_heap_constructor` (now this original feature only contains one function).

bors · 2024-05-31T18:24:03Z

💔 Test failed - checks-actions

jhpratt · 2024-06-01T00:01:42Z

Looks like x fmt needs to be run.

@bors d+

jhpratt · 2024-06-01T00:02:38Z

@bors r- d+

@Coekjan You should be able to respond with @bors r=jhpratt once you format the code. I thought the bot usually responded when using d+. If it doesn't work, don't worry — I'll get to it soon afterwards.

… `const_binary_heap_new_in` for `BinaryHeap::new_in`

Coekjan · 2024-06-01T04:46:41Z

@bors r=jhpratt

bors · 2024-06-01T04:46:43Z

@Coekjan: 🔑 Insufficient privileges: Not in reviewers

jhpratt · 2024-06-01T04:50:14Z

@bors r+

bors · 2024-06-01T04:50:16Z

📌 Commit 7cee7c6 has been approved by jhpratt

It is now in the queue for this repository.

Stablize `const_binary_heap_constructor` This pr aims to stablize `const_binary_heap_constructor`. `BinaryHeap::new` is able to be stablized, but `BinaryHeap::new_in` is not. Because the latter depends on `Vec::new_in` which is unstable. The `const_binary_heap_constructor` feature contains the two functions, and I want to split this feature now. This pr creates `const_binary_heap_new_in` feature for `BinaryHeap::new_in` and stablizes `const_binary_heap_constructor` (now this original feature only contains one function).

jieyouxu · 2024-06-01T06:09:36Z

@bors r- d+

@Coekjan You should be able to respond with @bors r=jhpratt once you format the code. I thought the bot usually responded when using d+. If it doesn't work, don't worry — I'll get to it soon afterwards.

@jhpratt I think you need to spell out "delegate+", don't think "d+" is recognized

Rollup of 3 pull requests Successful merges: - rust-lang#125211 (Stablize `const_binary_heap_constructor`) - rust-lang#125683 (Rewrite `suspicious-library`, `resolve-rename` and `incr-prev-body-beyond-eof` `run-make` tests in `rmake.rs` format) - rust-lang#125822 (Refactor `--print=check-cfg` test) r? `@ghost` `@rustbot` modify labels: rollup

jhpratt · 2024-06-01T06:21:17Z

Ah, okay. I went by https://bors.tech/documentation, but I also know that Rust uses its own fork. Looking at https://bors.rust-lang.org, it seems you're correct.

bors · 2024-06-01T07:10:58Z

⌛ Testing commit 7cee7c6 with merge 466be51...

bors · 2024-06-01T09:16:22Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 466be51 to master...

rust-timer · 2024-06-01T10:30:35Z

Finished benchmarking commit (466be51): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.776s -> 668.037s (0.19%)
Artifact size: 318.89 MiB -> 318.86 MiB (-0.01%)

Coekjan changed the title ~~stablize const_binary_heap_constructor~~ Stablize const_binary_heap_constructor May 17, 2024

rustbot assigned cuviper May 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 17, 2024

Coekjan mentioned this pull request May 17, 2024

Constification of BinaryHeap construction #112353

Closed

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 17, 2024

rustbot assigned Amanieu and unassigned cuviper May 17, 2024

jhpratt added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label May 21, 2024

rustbot assigned jhpratt and unassigned Amanieu May 21, 2024

dtolnay approved these changes May 31, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 31, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2024

stablize const_binary_heap_constructor & create an unstable feature…

7cee7c6

… `const_binary_heap_new_in` for `BinaryHeap::new_in`

Coekjan force-pushed the const-binary-heap branch from ef23a5b to 7cee7c6 Compare June 1, 2024 04:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 1, 2024

jhpratt mentioned this pull request Jun 1, 2024

Rollup of 4 pull requests #125838

Closed

This was referenced Jun 1, 2024

Rollup of 3 pull requests #125839

Closed

Rewrite suspicious-library, resolve-rename and incr-prev-body-beyond-eof run-make tests in rmake.rs format #125683

Merged

jhpratt mentioned this pull request Jun 1, 2024

Rollup of 3 pull requests #125840

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2024

bors merged commit 466be51 into rust-lang:master Jun 1, 2024
7 checks passed

rustbot added this to the 1.80.0 milestone Jun 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stablize `const_binary_heap_constructor` #125211

Stablize `const_binary_heap_constructor` #125211

Coekjan commented May 17, 2024 •

edited

Loading

rustbot commented May 17, 2024

cuviper commented May 17, 2024

jhpratt commented May 20, 2024

Coekjan commented May 21, 2024

jhpratt commented May 21, 2024

jhpratt commented May 21, 2024

Coekjan commented May 31, 2024 •

edited

Loading

rustbot commented May 31, 2024

dtolnay commented May 31, 2024

bors commented May 31, 2024

bors commented May 31, 2024

bors commented May 31, 2024

This comment has been minimized.

jhpratt commented Jun 1, 2024

jhpratt commented Jun 1, 2024 •

edited

Loading

Coekjan commented Jun 1, 2024

bors commented Jun 1, 2024

jhpratt commented Jun 1, 2024

bors commented Jun 1, 2024

jieyouxu commented Jun 1, 2024

jhpratt commented Jun 1, 2024

bors commented Jun 1, 2024

bors commented Jun 1, 2024

rust-timer commented Jun 1, 2024

Stablize const_binary_heap_constructor #125211

Stablize const_binary_heap_constructor #125211

Conversation

Coekjan commented May 17, 2024 • edited Loading

rustbot commented May 17, 2024

cuviper commented May 17, 2024

jhpratt commented May 20, 2024

Coekjan commented May 21, 2024

jhpratt commented May 21, 2024

jhpratt commented May 21, 2024

Coekjan commented May 31, 2024 • edited Loading

rustbot commented May 31, 2024

dtolnay commented May 31, 2024

bors commented May 31, 2024

bors commented May 31, 2024

bors commented May 31, 2024

This comment has been minimized.

jhpratt commented Jun 1, 2024

jhpratt commented Jun 1, 2024 • edited Loading

Coekjan commented Jun 1, 2024

bors commented Jun 1, 2024

jhpratt commented Jun 1, 2024

bors commented Jun 1, 2024

jieyouxu commented Jun 1, 2024

jhpratt commented Jun 1, 2024

bors commented Jun 1, 2024

bors commented Jun 1, 2024

rust-timer commented Jun 1, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Stablize `const_binary_heap_constructor` #125211

Stablize `const_binary_heap_constructor` #125211

Coekjan commented May 17, 2024 •

edited

Loading

Coekjan commented May 31, 2024 •

edited

Loading

jhpratt commented Jun 1, 2024 •

edited

Loading